Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rafter related configuration #5386

Merged

Conversation

kwiatekus
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove test configuration and other periodic jobs related to rafter testing

Related issue(s)
kyma-project/kyma#13155

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 5, 2022
@kwiatekus kwiatekus added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 5, 2022
@kwiatekus kwiatekus force-pushed the drop-rafter-related-configuration branch from a8ff8d3 to 1370e12 Compare June 20, 2022 09:06
Copy link
Contributor

@moelsayed moelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of notes..

Comment on lines 17 to 47
{path: "service-catalog", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("tests-generic"),
},
},
{path: "application-connector-tests", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("generic"),
},
},
{path: "application-registry-tests", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("generic"),
},
},
{path: "compass-runtime-agent", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("tests-generic"),
},
},
{path: "connection-token-handler-tests", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("generic"),
},
},
{path: "connector-service-tests", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
additionalOptions: []jobsuite.Option{
jobsuite.JobFileSuffix("generic"),
},
},
{path: "integration/api-gateway", image: tester.ImageGolangBuildpack1_16, suite: tester.NewGenericComponentSuite,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can please take a look at these? I think there might be rebase errors there...

@kwiatekus kwiatekus removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@moelsayed
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 20, 2022
@pPrecel
Copy link
Contributor

pPrecel commented Jun 20, 2022

/approve
/lgtm

@kyma-bot kyma-bot merged commit 49af222 into kyma-project:main Jun 20, 2022
@kyma-bot
Copy link
Contributor

@kwiatekus: Updated the following 2 configmaps:

  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file prow/config.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key kyma-integration.yaml using file prow/jobs/kyma/kyma-integration.yaml
    • key rafter.yaml using file ``
    • key whitesource-periodics.yaml using file prow/jobs/scans/whitesource-periodics.yaml
    • key checkconfig.yaml using file prow/jobs/test-infra/checkconfig.yaml
    • key third-party-images.yaml using file prow/jobs/third-party-images/third-party-images.yaml

In response to this:

Description

Changes proposed in this pull request:

  • Remove test configuration and other periodic jobs related to rafter testing

Related issue(s)
kyma-project/kyma#13155

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants