Change http response code based on backend error #16115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k15r
requested review from
nachtmaar,
marcobebway,
mfaizanse,
friedrichwilken,
vpaskar,
raypinto,
lilitgh and
muralov
as code owners
kyma-bot
added
the
size/L
4 tasks
vpaskar
reviewed
Nov 17, 2022
| @@ -26,6 +26,7 @@ const ( | |||
| natsBackend = "nats" | |||
| jestreamHandlerName = "jetstream-handler" | |||
| noSpaceLeftErrMessage = "no space left on device" | |||
| natsMaxBytesExceeded = "nats: maximum bytes exceeded" | |||
There was a problem hiding this comment.
can we use the ErrMaxBytes from nats-server library and use then errors.Is instead of checking for error text ?
There was a problem hiding this comment.
No we cannot, but i improved the code to evaluate the errorcode returned by the api
friedrichwilken
requested changes
Nov 17, 2022
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@k15r: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k15r
added a commit
to k15r/kyma
that referenced
this pull request
Nov 18, 2022
* introduce common errors to allow returning custom http responses * bump image * evaluate API Error returned by nats * fix code review comments
kyma-bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Change http response code based on backend error (#16115) * introduce common errors to allow returning custom http responses * bump image * evaluate API Error returned by nats * fix code review comments * update stream configuration according to env vars (#16111) * update stream configuration according to env vars * fix tests * disable strict shadowing linting, to allow shadowing of `err` * parse units in maxbytes environment * fix more tests * set discardPolicy * fix review comments * bump images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)