Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eventing from main #16122

Merged
merged 3 commits into from Nov 18, 2022
Merged

update eventing from main #16122

merged 3 commits into from Nov 18, 2022

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Nov 18, 2022

Description

Changes proposed in this pull request:

Related issue(s)

@k15r
Change http response code based on backend error (kyma-project#16115)
7feaf1e 
* introduce common errors to allow returning custom http responses

* bump image

* evaluate API Error returned by nats

* fix code review comments
@k15r
update stream configuration according to env vars (kyma-project#16111)
864655f 
* update stream configuration according to env vars

* fix tests

* disable strict shadowing linting, to allow shadowing of `err`

* parse units in maxbytes environment

* fix more tests

* set discardPolicy

* fix review comments
@k15r
bump images
e327a0a
@k15r k15r added the area/eventing Issues or PRs related to eventing label Nov 18, 2022
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2022
friedrichwilken
friedrichwilken approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2022
@friedrichwilken
Copy link
Contributor

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 18, 2022 •
edited

@k15r: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-event-publisher-proxy-lint e327a0a link false /test pull-event-publisher-proxy-lint
pull-eventing-controller-lint e327a0a link false /test pull-eventing-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k15r
Copy link
Contributor Author

k15r commented Nov 18, 2022

/test pull-event-publisher-proxy-lint

@k15r
Copy link
Contributor Author

k15r commented Nov 18, 2022

/test pull-eventing-controller-lint

@kyma-bot kyma-bot merged commit 89d62b2 into kyma-project:release-2.9 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@nachtmaar nachtmaar Awaiting requested review from nachtmaar nachtmaar is a code owner

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway is a code owner

@mfaizanse mfaizanse Awaiting requested review from mfaizanse mfaizanse is a code owner

@vpaskar vpaskar Awaiting requested review from vpaskar

@raypinto raypinto Awaiting requested review from raypinto

@lilitgh lilitgh Awaiting requested review from lilitgh lilitgh is a code owner

@muralov muralov Awaiting requested review from muralov muralov is a code owner

Assignees

@k15r k15r

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k15r @friedrichwilken @kyma-bot