Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign of telemetry/observability docu #16336

Merged
merged 18 commits into from Dec 19, 2022
Merged

Redesign of telemetry/observability docu #16336

merged 18 commits into from Dec 19, 2022

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Dec 12, 2022 •
edited

Description

Changes proposed in this pull request:

  • Introduced new telemetry area
  • Moved over telemetry logging part from observability area
  • Added new telemetry tracing section
  • Cleanup of old observability area

Related issue(s)

#11231

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit d22f340
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6396e60b24f6370008bab4cd
😎 Deploy Preview https://deploy-preview-16336--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@a-thaler
Copy link
Contributor Author

/test all

1 similar comment
@a-thaler
Copy link
Contributor Author

/test all

@a-thaler a-thaler mentioned this pull request Dec 12, 2022
Closed
34 tasks
grego952
grego952 reviewed Dec 13, 2022
View reviewed changes
docs/01-overview/main-areas/observability/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/observability/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/observability/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-01-operator.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-01-operator.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-01-operator.md Outdated Show resolved Hide resolved
@a-thaler a-thaler marked this pull request as ready for review December 13, 2022 13:32
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2022
grego952
grego952 reviewed Dec 13, 2022
View reviewed changes
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
a-thaler and others added 6 commits December 13, 2022 15:55
@a-thaler
moved spec outside
4f1820e
@a-thaler @grego952
Apply suggestions from code review
23db20e 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@a-thaler @grego952
Apply suggestions from code review
430dcde 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@a-thaler @grego952
Apply suggestions from code review
7cb5d49 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@a-thaler
fix
56315ba
@a-thaler @grego952
Apply suggestions from code review
f548133 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@skhalash skhalash changed the title redesign of telemetry/observability docu Redesign of telemetry/observability docu Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 58fd96f
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63a0439813ed8d000ae77d48
😎 Deploy Preview https://deploy-preview-16336--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 14, 2022 •
edited

@a-thaler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-function-java17-jvm-alpha-build 1001f4b link true /test pull-function-java17-jvm-alpha-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

grego952
grego952 reviewed Dec 16, 2022
View reviewed changes
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/observability/README.md Outdated Show resolved Hide resolved
docs/05-technical-reference/00-custom-resources/telemetry-02-logparser.md Outdated Show resolved Hide resolved
docs/05-technical-reference/00-custom-resources/telemetry-03-tracepipeline.md Outdated Show resolved Hide resolved
docs/05-technical-reference/00-custom-resources/telemetry-03-tracepipeline.md Outdated Show resolved Hide resolved
docs/05-technical-reference/00-custom-resources/telemetry-03-tracepipeline.md Outdated Show resolved Hide resolved
docs/05-technical-reference/00-custom-resources/telemetry-03-tracepipeline.md Outdated Show resolved Hide resolved
a-thaler and others added 2 commits December 16, 2022 15:16
@a-thaler @grego952
Apply suggestions from code review
84bdf94 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@a-thaler @grego952
Apply suggestions from code review
0abd79c 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
skhalash
skhalash previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@skhalash skhalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 16, 2022
@a-thaler @grego952
Apply suggestions from code review
e37f628 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 19, 2022
grego952
grego952 reviewed Dec 19, 2022
View reviewed changes
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/README.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-02-logs.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-03-traces.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-03-traces.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-03-traces.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-03-traces.md Outdated Show resolved Hide resolved
docs/01-overview/main-areas/telemetry/telemetry-03-traces.md Outdated Show resolved Hide resolved
@a-thaler @grego952
Apply suggestions from code review
58fd96f 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 19, 2022
@kyma-bot kyma-bot merged commit 77b9f95 into kyma-project:main Dec 19, 2022
@a-thaler a-thaler added this to the 2.10 milestone Dec 19, 2022
@a-thaler a-thaler added the area/tracing Issues or PRs related to the tracing module (deprecated) label Dec 19, 2022
k15r pushed a commit to k15r/kyma that referenced this pull request Dec 19, 2022
@a-thaler @grego952 @k15r
Redesign of telemetry/observability docu (kyma-project#16336)
b13ffda 
* redesign of telemetry/observability docu

* fix

* fix

* added missing parts

* moved spec outside

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* fix

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* merge

* fix

* fix example

* added secret rotation

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@a-thaler a-thaler deleted the docu branch December 19, 2022 15:55
This was referenced Dec 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@skhalash skhalash skhalash left review comments

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@NHingerl NHingerl Awaiting requested review from NHingerl

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

Assignees

@skhalash skhalash

@a-thaler a-thaler

@grego952 grego952

Labels
area/tracing Issues or PRs related to the tracing module (deprecated) lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a-thaler @kyma-bot @skhalash @grego952