adding istio tracing to the tracing documentation #16394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-thaler
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger and
nataliasitko
as code owners
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a-thaler
added
the
area/tracing
kyma-bot
added
the
size/M
chrkl
reviewed
Dec 20, 2022
Co-authored-by: Christoph Kleineweber <ckleineweber@gmail.com>
grego952
reviewed
Dec 20, 2022
|
|
||
| As used in the previous step, a Secret referenced with the **secretKeyRef** construct can be rotated manually or automatically. For automatic rotation, update the Secret's actual values and keep the Secret's keys stable. TracePipeline watches the referenced Secrets and detects changes, so the Secret rotation takes immediate effect. When using a Secret owned by the [SAP BTP Operator](https://github.com/SAP/sap-btp-service-operator), you can configure `credentialsRotationPolicy` with a specific `rotationFrequency` to achieve an automated rotation. | ||
|
|
||
| ## Kyma Components with tracing capabilities | ||
|
|
||
| Kyma bundles several modules which are potentially involved in user flows and with must propagate the trace context properly and optional provide custom spans. |
There was a problem hiding this comment.
Is this sentence complete? Can you elaborate on its meaning?
There was a problem hiding this comment.
I improved it. I agree that a general explanation of the topic would help. That would need to be done in the intro. I might add it at a later time.
kyma-bot
added
size/L
a-thaler
commented
Dec 20, 2022
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
reviewed
Dec 20, 2022
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#16336