Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TracePipeline has wrong status #16666

Merged
merged 15 commits into from Jan 30, 2023

Conversation

hisarbalik
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Wrong ready opentelemetry collector pods check fixed

Related issue(s)
#16531

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 0ed03ca
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63d79f4a06f5860008f7e551
😎 Deploy Preview https://deploy-preview-16666--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2023
@hisarbalik hisarbalik linked an issue Jan 26, 2023 that may be closed by this pull request
@skhalash skhalash self-assigned this Jan 26, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2023
@hisarbalik
Copy link
Contributor Author

/retest

Copy link
Contributor

@skhalash skhalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the image tag

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2023
Copy link
Contributor

@skhalash skhalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions to improve error handling

hisarbalik and others added 2 commits January 30, 2023 07:54
@hisarbalik
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 30, 2023
@kyma-bot kyma-bot merged commit 5b1b707 into kyma-project:main Jan 30, 2023
@a-thaler a-thaler added the area/tracing Issues or PRs related to the tracing module (deprecated) label Jan 30, 2023
a-thaler added a commit to a-thaler/kyma that referenced this pull request Feb 1, 2023
* main: (61 commits)
  switch owners of observability components to github team approach (kyma-project#16704)
  Replace PSP with PSA for Eventing components (kyma-project#16681)
  Migrate connectivity validator after operator removal (kyma-project#16693)
  Telemetry integration test retry operations (kyma-project#16689)
  Bump NATS image to 2.9.11 (kyma-project#16690)
  Migrate Compass Runtime Agent after Application Operator removal (kyma-project#16677)
  bump image tags (kyma-project#16695)
  language review Eventing Controller (kyma-project#15907)
  Fix empty response case from async nodejs16 runtime (kyma-project#16675)
  Pod preset cleanup (kyma-project#16647)
  Cleanup event types in conversion webhook for v1alpha2 Subscription (kyma-project#16646)
  Fix TracePipeline has wrong status (kyma-project#16666)
  update of alpine and golang version for telemetry/observability images (kyma-project#16682)
  validate source for valid URI (kyma-project#16671)
  Remove application operator (kyma-project#16660)
  Bump the net library (kyma-project#16680)
  gomod(deps): bump github.com/onsi/gomega from 1.25.0 to 1.26.0 in /components/event-publisher-proxy (kyma-project#16652)
  gomod(deps): bump github.com/onsi/gomega from 1.25.0 to 1.26.0 in /components/eventing-controller (kyma-project#16657)
  Update version of autoscaling in Ory charts (kyma-project#16676)
  Bump net (kyma-project#16661)
  ...

# Conflicts:
#	components/telemetry-operator/config/rbac/role.yaml
#	components/telemetry-operator/controller/tracepipeline/controller.go
#	components/telemetry-operator/controller/tracepipeline/resources.go
#	components/telemetry-operator/controller/tracepipeline/setup.go
#	components/telemetry-operator/controller/tracepipeline/suite_test.go
#	resources/telemetry/charts/fluent-bit/templates/servicemonitor.yaml
#	resources/telemetry/charts/fluent-bit/values.yaml
#	resources/telemetry/charts/operator/templates/role.yaml
#	resources/telemetry/values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing Issues or PRs related to the tracing module (deprecated) lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TracePipeline has running state without deploying otel-collector
4 participants