Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More resilient telemetry integration test #16689

Merged
merged 13 commits into from Jan 31, 2023

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Jan 30, 2023

Description

Many integration test cases failing due to the underlaying system limitations. Main problem is overloaded k8s API-Server during test execution.

Changes proposed in this pull request:

  • Execute the test cases in a retry mechanism with predefined delay between execution attempts (e.g. k8s API-Server not responsive)
  • Retry accessing deployed mock components or mock data in case of mocks are not ready yet.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit f4184ba
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63d92227d6be32000970c3f0
😎 Deploy Preview https://deploy-preview-16689--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2023
@hisarbalik
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

1 similar comment
@hisarbalik
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@hisarbalik hisarbalik self-assigned this Jan 31, 2023
@hisarbalik hisarbalik changed the title Telemetry integration test retry operation Telemetry integration test retry operations Jan 31, 2023
@hisarbalik hisarbalik added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@hisarbalik
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

@hisarbalik hisarbalik removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 31, 2023
@kyma-bot kyma-bot merged commit 7432f96 into kyma-project:main Jan 31, 2023
@hisarbalik hisarbalik deleted the fix-telemetry-integration-test branch January 31, 2023 15:01
@a-thaler a-thaler changed the title Telemetry integration test retry operations More resilient telemetry integration test Feb 1, 2023
@a-thaler a-thaler added the area/tracing Issues or PRs related to the tracing module (deprecated) label Feb 1, 2023
@a-thaler a-thaler added this to the 2.11 milestone Feb 1, 2023
a-thaler added a commit to a-thaler/kyma that referenced this pull request Feb 1, 2023
* main: (61 commits)
  switch owners of observability components to github team approach (kyma-project#16704)
  Replace PSP with PSA for Eventing components (kyma-project#16681)
  Migrate connectivity validator after operator removal (kyma-project#16693)
  Telemetry integration test retry operations (kyma-project#16689)
  Bump NATS image to 2.9.11 (kyma-project#16690)
  Migrate Compass Runtime Agent after Application Operator removal (kyma-project#16677)
  bump image tags (kyma-project#16695)
  language review Eventing Controller (kyma-project#15907)
  Fix empty response case from async nodejs16 runtime (kyma-project#16675)
  Pod preset cleanup (kyma-project#16647)
  Cleanup event types in conversion webhook for v1alpha2 Subscription (kyma-project#16646)
  Fix TracePipeline has wrong status (kyma-project#16666)
  update of alpine and golang version for telemetry/observability images (kyma-project#16682)
  validate source for valid URI (kyma-project#16671)
  Remove application operator (kyma-project#16660)
  Bump the net library (kyma-project#16680)
  gomod(deps): bump github.com/onsi/gomega from 1.25.0 to 1.26.0 in /components/event-publisher-proxy (kyma-project#16652)
  gomod(deps): bump github.com/onsi/gomega from 1.25.0 to 1.26.0 in /components/eventing-controller (kyma-project#16657)
  Update version of autoscaling in Ory charts (kyma-project#16676)
  Bump net (kyma-project#16661)
  ...

# Conflicts:
#	components/telemetry-operator/config/rbac/role.yaml
#	components/telemetry-operator/controller/tracepipeline/controller.go
#	components/telemetry-operator/controller/tracepipeline/resources.go
#	components/telemetry-operator/controller/tracepipeline/setup.go
#	components/telemetry-operator/controller/tracepipeline/suite_test.go
#	resources/telemetry/charts/fluent-bit/templates/servicemonitor.yaml
#	resources/telemetry/charts/fluent-bit/values.yaml
#	resources/telemetry/charts/operator/templates/role.yaml
#	resources/telemetry/values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing Issues or PRs related to the tracing module (deprecated) lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants