Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable managed fluent-bit #16668

Merged
merged 20 commits into from Feb 2, 2023
Merged

Enable managed fluent-bit #16668

merged 20 commits into from Feb 2, 2023

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Jan 26, 2023 •
edited

Description

Changes proposed in this pull request:

  • Enable managed fluent-bit and removed the feature flag
  • Deleted fluent bit charts
  • Moved servicemonitor, peerauthentication and dashboards in managed-flunet-bit folder
  • Changed the logic to have fluent bit daemonset created only after the checksum is calculated.
  • Changed the secret roles to be restrict controller to read secrets from all namespaces and write to only kyma-system
  • Delete the finalizer after the fluent-bit is reconciled as it may lead to race conditions sometimes where api server might remove the CR before we validate if fluent-bit daemon set should be deleted. And cause failure of deletion of fluent-bit resources when last pipeline is deleted.
  • Restricted the rights of telemetry-operator

Related issue(s)

16570

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2023
@netlify
Copy link

netlify bot commented Jan 26, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit daa2136
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63db814d1efb2b000710ba41
😎 Deploy Preview https://deploy-preview-16668--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rakesh-garimella
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2023
@kyma-bot kyma-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2023
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2023
@rakesh-garimella
Copy link
Contributor Author

/test all

@rakesh-garimella rakesh-garimella marked this pull request as ready for review January 30, 2023 10:21
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@rakesh-garimella
some more improvements
409350d 
- removed fluent-bit charts
- provide roles for telemetry operator
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2023
@rakesh-garimella
Copy link
Contributor Author

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@rakesh-garimella
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner February 1, 2023 14:07
@rakesh-garimella
Copy link
Contributor Author

/test pull-telemetry-operator-unit-test

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 2, 2023
@kyma-bot kyma-bot merged commit eaaef03 into kyma-project:main Feb 2, 2023
@rakesh-garimella rakesh-garimella deleted the fluentbit-removal-laststep branch February 2, 2023 09:43
a-thaler added a commit to a-thaler/kyma that referenced this pull request Feb 2, 2023
@a-thaler
Merge branch 'main' into annotations
1507287 
* main:
  Upgrade runtimes bases (kyma-project#16714)
  Enable managed fluent-bit (kyma-project#16668)
  Fix content-type header check in python runtime (kyma-project#16706)
  Adding configuration to debug python function and example of custom HTTP response in python to docs (kyma-project#16669)

# Conflicts:
#	components/telemetry-operator/config/rbac/role.yaml
#	resources/telemetry/charts/fluent-bit/templates/service.yaml
#	resources/telemetry/charts/fluent-bit/values.yaml
#	resources/telemetry/charts/operator/templates/fluent-bit/service-monitor.yaml
#	resources/telemetry/charts/operator/templates/role.yaml
#	resources/telemetry/values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrkl chrkl chrkl approved these changes

@skhalash skhalash skhalash approved these changes

@a-thaler a-thaler Awaiting requested review from a-thaler

@lindnerby lindnerby Awaiting requested review from lindnerby

@dennis-ge dennis-ge Awaiting requested review from dennis-ge

@lilitgh lilitgh Awaiting requested review from lilitgh

@hisarbalik hisarbalik Awaiting requested review from hisarbalik

Assignees

@chrkl chrkl

@skhalash skhalash

Labels
lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rakesh-garimella @kyma-bot @chrkl @skhalash