Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Operator] Finalize fluent-bit managed by operator #16570

Closed
a-thaler opened this issue Jan 16, 2023 · 6 comments
Closed

[Telemetry Operator] Finalize fluent-bit managed by operator #16570

a-thaler opened this issue Jan 16, 2023 · 6 comments
Assignees
Labels
area/logging Issues or PRs related to the logging module (deprecated)
Milestone

Comments

@a-thaler
Copy link
Contributor

a-thaler commented Jan 16, 2023

Description
As part of #15955 the kyma fluent-bit instances are manageable by code already but the feature is not activated yet and will be still realized via a helm chart. Finalize the efforts by testing the migration fully and fixing leftovers.

Criterias:

  • All resources of the old fluent-bit sub-chart are either managed by code (new telemetry-operator functionality), are moved to the umbrella telemetry chart (and will be managed by old logic) or are deleted (automated or manual migration script?)
    • Potential resources of interest are: Grafana Dashboards, ServiceMonitors, PeerAuthentication
    • Agreement for ServiceAccount is to also manage it by the operator with least privileges (remember to limit the namespace). It includes the ServiceAccount, a Role and a RoleBinding
  • Feature flag got removed
  • temporary integration test got merged into regular test suite
  • Old fluent-bit sub-chart does not exist anymore
  • Migration/Upgrade from helm chart approach to managed by code approach is tested
  • Try to verify that automated upgrade tests will not fail
  • add missing test cases
    • no logpipeline reveals in no fluentbit
    • deletion of logpipelines will remove fluentbit when reaching an amount pipelines of 0

Reasons

Attachments

@a-thaler a-thaler added the area/logging Issues or PRs related to the logging module (deprecated) label Jan 16, 2023
@rakesh-garimella rakesh-garimella self-assigned this Jan 24, 2023
@rakesh-garimella
Copy link
Contributor

rakesh-garimella commented Feb 2, 2023

Following tasks have been performed:

  • Removed telemetry alpha job: remove telemetry alpha job test-infra#6861
  • Enable managed fluent-bit and removed the feature flag
  • Deleted fluent bit charts
  • Moved servicemonitor, peerauthentication and dashboards in flunet-bit folder
  • Changed the logic to have fluent bit daemonset created only after the checksum is calculated.
  • Fixed deletion logic
  • Restricted the rights of telemetry-operator

The automated tests will be updated via a separated PR

@rakesh-garimella
Copy link
Contributor

PR for automated tests have been added here: https://github.com/kyma-project/kyma/pull/16726/files

@a-thaler
Copy link
Contributor Author

a-thaler commented Feb 3, 2023

production profile is ignored, will re-open till it is respected

@a-thaler a-thaler reopened this Feb 3, 2023
@a-thaler a-thaler added this to the 2.11 milestone Feb 3, 2023
@a-thaler
Copy link
Contributor Author

a-thaler commented Feb 3, 2023

The containerPort 2021 is exposed by both containers, fluentbit and directory-size-exporter. WHich one will be used? I'm very sure that fluentbit should expose only the 2020 port and that this must be a mistake, please verify that

@a-thaler
Copy link
Contributor Author

a-thaler commented Feb 3, 2023

The generated luascript is broken.
The line local mapped_key = string.gsub(key, "[%/%.]", "_") contains escaping characters which breaks fluentbit startup local mapped_key = string.gsub(key, \"[%/%.]\", \"_\")

@a-thaler
Copy link
Contributor Author

a-thaler commented Feb 6, 2023

Mentioned issues are addressed

@a-thaler a-thaler closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to the logging module (deprecated)
Projects
None yet
Development

No branches or pull requests

2 participants