Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left over issues with managed fluentbit #16734

Merged
merged 3 commits into from Feb 3, 2023

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Feb 3, 2023

Description

Changes proposed in this pull request:

  • Pass the images for fluentbit via cli
  • Pass the priority class via cli
  • Pass the fluentbit resource req/limits via cli
  • Fix the issue when 1 of 2 pipelines are deleted is not causing restart of the fluent bit daemon set
  • Remove extra 2021 port on the fluent bit
  • Fix the lua script

Related issue(s)

#16570

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner February 3, 2023 16:06
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 47928d1
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63dd3511ef5a0000089e37f2
😎 Deploy Preview https://deploy-preview-16734--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2023
@rakesh-garimella rakesh-garimella changed the title Fix fb res Fix left over issues with managed fluentbit Feb 3, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 3, 2023

@rakesh-garimella: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-azure-alpha-eval 47928d1 link false /test pre-main-kyma-gardener-azure-alpha-eval

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-thaler
Copy link
Contributor

a-thaler commented Feb 3, 2023

I tested the mentioned points manually and all worked fine

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2023
@kyma-bot kyma-bot merged commit f88ec68 into kyma-project:main Feb 3, 2023
@rakesh-garimella rakesh-garimella deleted the fix-fb-res branch February 6, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants