Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps dependencies in application-connector components #17544

Merged
merged 15 commits into from
May 23, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented May 22, 2023

Description

Changes proposed in this pull request:

  • bump k8s.io/api from 0.26.3 to 0.26.5 in /components/compass-runtime-agent
  • bump k8s.io/client-go from 0.26.3 to 0.26.5 in /components/compass-runtime-agent
  • bump k8s.io/metrics from 0.26.3 to 0.26.5 in /components/compass-runtime-agent
  • bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /components/compass-runtime-agent
  • bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /components/central-application-connectivity-validator
  • bump k8s.io/client-go from 0.26.3 to 0.26.5 in /components/central-application-connectivity-validator
  • bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /components/central-application-gateway
  • bump k8s.io/client-go from 0.27.0 to 0.27.2 in /components/central-application-gateway

Related issue(s)

dependabot bot and others added 14 commits May 19, 2023 08:48
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.0 to 0.27.2.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.27.0...v0.27.2)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.3 to 0.26.5.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.26.3...v0.26.5)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/metrics](https://github.com/kubernetes/metrics) from 0.26.3 to 0.26.5.
- [Commits](kubernetes/metrics@v0.26.3...v0.26.5)

---
updated-dependencies:
- dependency-name: k8s.io/metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.3 to 0.26.5.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.26.3...v0.26.5)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.26.3 to 0.26.5.
- [Commits](kubernetes/api@v0.26.3...v0.26.5)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…/compass-runtime-agent/k8s.io/api-0.26.5' into app_conn_dependabot_22_05
…/compass-runtime-agent/k8s.io/client-go-0.26.5' into app_conn_dependabot_22_05
…/compass-runtime-agent/k8s.io/metrics-0.26.5' into app_conn_dependabot_22_05
…/central-application-connectivity-validator/github.com/stretchr/testify-1.8.3' into app_conn_dependabot_22_05
…/central-application-connectivity-validator/k8s.io/client-go-0.26.5' into app_conn_dependabot_22_05
…/central-application-gateway/github.com/stretchr/testify-1.8.3' into app_conn_dependabot_22_05
…/central-application-gateway/k8s.io/client-go-0.27.2' into app_conn_dependabot_22_05
@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label May 22, 2023
@Disper Disper added this to the 2.15 milestone May 22, 2023
@Disper Disper requested a review from a team as a code owner May 22, 2023 08:57
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 019788a
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/646b431fde8b3d0008f04274
😎 Deploy Preview https://deploy-preview-17544--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2023
@kyma-bot
Copy link
Contributor

@Disper: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kyma-presubmit-scanner 019788a link false /test pre-kyma-presubmit-scanner

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

github.com/vrischmann/envconfig v1.3.0
go.uber.org/zap v1.24.0
k8s.io/apimachinery v0.27.2
k8s.io/client-go v0.26.3
k8s.io/client-go v0.26.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to bump the versions of k8s.io/client-go k8s.io/api k8s.io/metrics so that the same package version is used in all components?

Copy link
Member Author

@Disper Disper May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's not yetpossible as after upgrade it might fail with errors such as this:

/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/cache/multi_namespace_cache.go:321:9: cannot use handles (variable of type map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration) as "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration value in return statement: map[string]"k8s.io/
client-go/tools/cache".ResourceEventHandlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSynced)
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/cache/multi_namespace_cache.go:326:17: impossible type assertion: h.(map[string]toolscache.ResourceEventHandlerRegistration)
map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSynced)

We do have an item in the backlog to revisit that after controller-runtime will release it's 0.15.0 version.

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 23, 2023
@kyma-bot kyma-bot merged commit 3dae9f1 into kyma-project:main May 23, 2023
18 of 19 checks passed
@Disper Disper deleted the app_conn_dependabot_22_05 branch May 24, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants