-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps dependencies in application-connector components #17544
Bumps dependencies in application-connector components #17544
Conversation
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.0 to 0.27.2. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.27.0...v0.27.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.3 to 0.26.5. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.26.3...v0.26.5) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/metrics](https://github.com/kubernetes/metrics) from 0.26.3 to 0.26.5. - [Commits](kubernetes/metrics@v0.26.3...v0.26.5) --- updated-dependencies: - dependency-name: k8s.io/metrics dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.3 to 0.26.5. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.26.3...v0.26.5) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.26.3 to 0.26.5. - [Commits](kubernetes/api@v0.26.3...v0.26.5) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…/compass-runtime-agent/k8s.io/api-0.26.5' into app_conn_dependabot_22_05
…/compass-runtime-agent/k8s.io/client-go-0.26.5' into app_conn_dependabot_22_05
…/compass-runtime-agent/k8s.io/metrics-0.26.5' into app_conn_dependabot_22_05
…/central-application-connectivity-validator/github.com/stretchr/testify-1.8.3' into app_conn_dependabot_22_05
…/central-application-connectivity-validator/k8s.io/client-go-0.26.5' into app_conn_dependabot_22_05
…/central-application-gateway/github.com/stretchr/testify-1.8.3' into app_conn_dependabot_22_05
…/central-application-gateway/k8s.io/client-go-0.27.2' into app_conn_dependabot_22_05
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@Disper: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
github.com/vrischmann/envconfig v1.3.0 | ||
go.uber.org/zap v1.24.0 | ||
k8s.io/apimachinery v0.27.2 | ||
k8s.io/client-go v0.26.3 | ||
k8s.io/client-go v0.26.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to bump the versions of k8s.io/client-go
k8s.io/api
k8s.io/metrics
so that the same package version is used in all components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately that's not yetpossible as after upgrade it might fail with errors such as this:
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/cache/multi_namespace_cache.go:321:9: cannot use handles (variable of type map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration) as "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration value in return statement: map[string]"k8s.io/
client-go/tools/cache".ResourceEventHandlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSynced)
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/cache/multi_namespace_cache.go:326:17: impossible type assertion: h.(map[string]toolscache.ResourceEventHandlerRegistration)
map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSynced)
We do have an item in the backlog to revisit that after controller-runtime
will release it's 0.15.0 version.
Description
Changes proposed in this pull request:
Related issue(s)