Rename BUC CRs domain to kyma-project.io #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polskikiel
added
kind/feature
polskikiel
requested review from
adamwalach,
aerfio,
akucharska,
antiheld,
aszecowka,
bszwarc,
dariadomagala-sap,
hardl,
jasiu001,
jesusreal,
joek,
k15r,
kazydek,
klaudiagrz,
kubadz,
kwiatekus,
lilitgh,
magicmatatjahu,
maxmarkus,
hudymi,
mjasinski5,
mszostok,
pekura,
piotrmiskiewicz,
piotrmsc,
PK85,
pkosiec and
rakesh-garimella
as code owners
polskikiel
requested review from
sayanh,
sjanota,
tomekpapiernik,
venturasr and
y-kkamil
as code owners
polskikiel
changed the title
polskikiel
changed the title
mszostok
approved these changes
Dec 20, 2018
| @@ -20,7 +20,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| finalizerName = "servicecatalog.kyma.cx/usage-kind-protection" | |||
| finalizerName = "servicecatalog.kyma-project.io/usage-kind-protection" | |||
There was a problem hiding this comment.
suggestion
What do you think about this approach?
var finalizerName = fmt.Sprintf("%s/usage-kind-protection", v1alpha1.SchemeGroupVersion.Group)
thanks to that in future we will not maintain that, what do u think?
There was a problem hiding this comment.
I believe that we won't change the domain name again. But you never know how kyma will look like tomorrow, so I will apply your suggestion 👍
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
* buildpack java-node fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)