Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade minikube and K8S version #2346

Merged
merged 8 commits into from
Jan 30, 2019
Merged

Upgrade minikube and K8S version #2346

merged 8 commits into from
Jan 30, 2019

Conversation

abbi-gaurav
Copy link
Member

@abbi-gaurav abbi-gaurav commented Jan 17, 2019 •
edited
Loading

Description

  • Use Minikube version : 0.33.0
  • Use Kubernetes version : 1.11.5
  • Update minikube.sh
  • Update minikube.ps1
  • Update ci build files
  • Update details for local installation

To Do

  • Verify console UI access (minikube)
  • Verify tests pass with minikube
    • all tests passed except test-core-core-ui-acceptance
    • confirmed with @hardl that it is not an upgrading related problem
  • Verify e2e scenario locally
  • Verify RBAC
  • Verify on windows installation @venturasr verified.
  • Update prow to use new version
  • Fix error statements in the installation run. (They are not causing any issues at present as it seems) See comment
  • install on GKE (follow up with farros installation)
    • run e2e tests against GKE installation
  • Verify with feature gates
    • knative
    • xoip (not required to verify as not yet in a working state)
  • ensure all admission plugins are applied
  • Check impact on the installer code. Does the operator needs to be upgraded?
  • Finalize the minikube, kubectl and kubernetes version
    • Currently 0.33.0, 1.11.0 and 1.11.5 are used.
  • Impact on controllers/operators in Kyma
  • Any missing documentation

@abbi-gaurav
Copy link
Member Author

Errors outputs in installation

E0117 13:57:54.053845   26631 status.go:137] Error executing status template: template: status:1:2: executing "status" at <.MinikubeStatus>: can't evaluate field MinikubeStatus in type cmd.Status
minikube is not currently running so the service cannot be accessed
Starting local Kubernetes v1.11.3 cluster...
Starting VM...
Getting VM IP address...
E0117 13:58:29.152774   26634 start.go:210] Error parsing version semver:  Version string empty

@abbi-gaurav
Copy link
Member Author

Prow job for integration test has currently hard-coded k8s version (v0.28.2). Waiting for a change from the prow side to watch for changes in the file https://github.com/kyma-project/kyma/blob/master/prow/kyma-integration-on-debian/install-deps-debian.sh

This will enable the build job for verification to succeed.

As discussed with @suleymanakbas91, going further, we should consider making the tooling versions updatable via a file in Kyma repository so that they can be made a part of the PR.

@abbi-gaurav abbi-gaurav added area/eventing Issues or PRs related to eventing area/ci Issues or PRs related to CI related topics wg/knative labels Jan 21, 2019
@abbi-gaurav
Copy link
Member Author

/test pre-master-kyma-gke-integration

@abbi-gaurav abbi-gaurav changed the title Upgrade K8S version to 1.11.5 Upgrade minikube and K8S version Jan 24, 2019
@abbi-gaurav abbi-gaurav force-pushed the upgrade-k8s branch 3 times, most recently from c353dcf to aef4db2 Compare January 28, 2019 13:20
@abbi-gaurav
Copy link
Member Author

/test pre-master-kyma-integration

@abbi-gaurav
Copy link
Member Author

/test pre-master-kyma-gke-integration

1 similar comment
@abbi-gaurav
Copy link
Member Author

/test pre-master-kyma-gke-integration

@kyma-bot
Copy link
Contributor

kyma-bot commented Jan 28, 2019 •
edited
Loading

@abbi-gaurav: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pre-master-kyma-gke-upgrade 4ffe363 link /test pre-master-kyma-gke-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@piotrmsc
Copy link

Verified components: istio, installer, api-controller, ns controller and it works on a cluster. LGTM.
Mentioned components do not need to upgrade k8s libs.

@abbi-gaurav
Copy link
Member Author

abbi-gaurav commented Jan 29, 2019 •
edited
Loading

waiting for the PR #2395 to be merged first. This contains changes to not use the k8s-dashboard service.

@abbi-gaurav
Copy link
Member Author

/test kyma-governance

1 similar comment
@abbi-gaurav
Copy link
Member Author

/test kyma-governance

@abbi-gaurav abbi-gaurav merged commit 623fcc1 into kyma-project:master Jan 30, 2019
@abbi-gaurav
Copy link
Member Author

See also #2276

@kubadz kubadz mentioned this pull request Jan 31, 2019
Merged
@pbochynski pbochynski mentioned this pull request Feb 26, 2019
Closed
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
report: false to jobs that should not report to prow, as it seems tha…
be4210a 
…t just adding the empty channel doesnt work (kyma-project#2346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venturasr venturasr venturasr approved these changes

@sjanota sjanota sjanota approved these changes

@bszwarc bszwarc bszwarc approved these changes

@piotrmsc piotrmsc piotrmsc approved these changes

@PK85 PK85 Awaiting requested review from PK85

@adamwalach adamwalach Awaiting requested review from adamwalach

@aszecowka aszecowka Awaiting requested review from aszecowka

@crabtree crabtree Awaiting requested review from crabtree

@Demonsthere Demonsthere Awaiting requested review from Demonsthere

@jakkab jakkab Awaiting requested review from jakkab

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@kazydek kazydek Awaiting requested review from kazydek

@kfurgol kfurgol Awaiting requested review from kfurgol

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@kubadz kubadz Awaiting requested review from kubadz

@mszostok mszostok Awaiting requested review from mszostok

@mwieczorek mwieczorek Awaiting requested review from mwieczorek

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@polskikiel polskikiel Awaiting requested review from polskikiel

@strekm strekm Awaiting requested review from strekm

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees
No one assigned
Labels
area/ci Issues or PRs related to CI related topics area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abbi-gaurav @kyma-bot @piotrmsc @venturasr @sjanota @bszwarc