Introduce Bucket controller for Asset Store #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
kind/feature
pkosiec
requested review from
a-thaler,
bszwarc,
derberg,
kazydek,
klaudiagrz,
lszymik,
pbochynski,
piotrmsc,
PK85 and
tomekpapiernik
as code owners
pkosiec
commented
Jan 25, 2019
components/assetstore-controller-manager/pkg/apis/assetstore/v1alpha1/bucket_types.go
Outdated
Show resolved
Hide resolved
components/assetstore-controller-manager/pkg/apis/assetstore/v1alpha1/bucket_types.go
Show resolved
Hide resolved
|
Oh, I forgot to update CODEOWNERS. I will do that after review 🙂 |
crabtree
reviewed
Jan 28, 2019
hudymi
approved these changes
Jan 28, 2019
components/assetstore-controller-manager/config/samples/assetstore_v1alpha1_bucket.yaml
Show resolved
Hide resolved
components/assetstore-controller-manager/pkg/controller/bucket/bucket_controller.go
Outdated
Show resolved
Hide resolved
components/assetstore-controller-manager/pkg/controller/bucket/bucket_controller.go
Outdated
Show resolved
Hide resolved
components/assetstore-controller-manager/pkg/buckethandler/buckethandler.go
Outdated
Show resolved
Hide resolved
hudymi
reviewed
Jan 28, 2019
components/assetstore-controller-manager/pkg/controller/bucket/bucket_controller.go
Outdated
Show resolved
Hide resolved
derberg
approved these changes
Jan 28, 2019
kazydek
reviewed
Jan 29, 2019
kazydek
approved these changes
Jan 29, 2019
Co-Authored-By: pkosiec <pawel.kosiec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #2269