-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a v2 API to publish events that conforms to cloud events specification #4687
Provide a v2 API to publish events that conforms to cloud events specification #4687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests for v2 publish API should be added
Request:
HTTP/1.1 400 Bad Request Response:
The response doesn't say what is missing. |
@@ -0,0 +1,77 @@ | |||
package v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file? I find it similar to components/event-bus/api/publish/error.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to consolidate the APIs files, so we can easily remove the v1
in the future
For the kyma/components/event-service, I get |
components/event-bus/cmd/event-bus-publish-knative/handlers/publish.go
Outdated
Show resolved
Hide resolved
components/event-bus/cmd/event-bus-publish-knative/handlers/publish.go
Outdated
Show resolved
Hide resolved
Publishing from an application gives 404:
|
@sayanh This is working now after changing the
|
/test pre-master-kyma-components-application-connectivity-validator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing build.
components/application-connectivity-validator/cmd/applicationconnectivityvalidator/options.go
Show resolved
Hide resolved
Following need to be done:
|
components/event-bus/cmd/event-bus-publish-knative/validators/publish_validator.go
Show resolved
Hide resolved
You might want to add some acceptance tests for the Event Service V2 as I do not think the existing tests cover this. |
5ae8f44
to
c8f9ba8
Compare
See also #4389