Add Compass Runtime Agent acceptance tests #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymongib
added
kind/feature
Szymongib
requested review from
akgalwas,
aszecowka,
crabtree,
franpog859,
janmedrek,
kfurgol,
Maladie,
PK85,
pkosiec and
tgorgol
as code owners
|
/test pre-master-kyma-gke-compass-integration |
akgalwas
reviewed
Aug 12, 2019
| c.assertEventAPIs(t, appId, compassEventAPIs, appCR) | ||
| } | ||
|
|
||
| func (c *K8sResourceChecker) AssertEventAPIResourcesDeleted(t *testing.T, applicationId, eventAPIId string) { |
There was a problem hiding this comment.
This function is identical to "AssertAPIResourcesDeleted".
| data: "{{.Data}}", | ||
| {{- end}} | ||
| {{- if .FetchRequest }} | ||
| fetchRequest: {{- FetchRequesstInputToGQL .FetchRequest }} |
There was a problem hiding this comment.
Typo: FetchRequesstInputToGQL.
akgalwas
approved these changes
Aug 14, 2019
| case *graphql.OAuthCredentialData: | ||
| return fmt.Sprintf("%s/%s/%s", mock.OAuth, cred.ClientID, cred.ClientSecret) | ||
| default: | ||
| t.Fatalf("Failed to get path based on authentication: unkonw credentials type") |
| case *graphql.OAuthCredentialData: | ||
| c.assertK8sOAuthSecret(t, secretName, cred, service) | ||
| default: | ||
| t.Fatalf("Unkonw credentials type") |
| // update no auth API to OAuth | ||
| noAuthAPI, found := getAPIByName(application.APIs.Data, "no-auth-api") | ||
| require.True(t, found) | ||
| updatedInput := applications.NewAPI("basic-to-oauth", "", noAuthAPI.TargetURL).WithAuth(oauth) |
There was a problem hiding this comment.
"no-auth-to-oauth" instead of "basic-to-oauth"?
| require.NoError(t, err) | ||
| updatedAPIs = append(updatedAPIs, newBasicAuthAPI) | ||
|
|
||
| // update OAuth API to Basic Auth |
There was a problem hiding this comment.
"update BasicAuth to no auth"?
|
/retest |
|
@Szymongib: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)