Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local and cluster configs - overrides #639

Merged
merged 4 commits into from
Sep 13, 2018
Merged

Local and cluster configs - overrides #639

merged 4 commits into from
Sep 13, 2018

Conversation

crabtree
Copy link
Contributor

@crabtree crabtree commented Sep 12, 2018

Description

Changes proposed in this pull request:

  • Split local and cluster config into separate files

Related issue(s)
Resolves #629

@crabtree crabtree removed the WIP label Sep 12, 2018
global.etcdBackup.enabled: "__ENABLE_ETCD_BACKUP__"
global.alertTools.credentials.slack.apiurl: "__SLACK_API_URL_VALUE__"
global.alertTools.credentials.slack.channel: "__SLACK_CHANNEL_VALUE__"
global.alertTools.credentials.victorOps.routingkey: "__VICTOR_OPS_API_KEY_VALUE__"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ROUTING_KEY"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

installer: overrides
type: Opaque
data:
test.auth.username: "YWRtaW5Aa3ltYS5jeA==" # admin@kyma.cx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@kazydek kazydek added the area/documentation Issues or PRs related to documentation label Sep 13, 2018
@crabtree crabtree added the area/installation Issues or PRs related to installation label Sep 13, 2018
@crabtree crabtree merged commit 0298d7e into kyma-project:master Sep 13, 2018
@crabtree crabtree deleted the local-and-cluster-configs branch September 13, 2018 07:57
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/installation Issues or PRs related to installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants