Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDP Preset overwritten on Lambda Save #6678

Merged
merged 6 commits into from
Dec 19, 2019
Merged

IDP Preset overwritten on Lambda Save #6678

merged 6 commits into from
Dec 19, 2019

Conversation

Wawrzyn321
Copy link
Contributor

@Wawrzyn321 Wawrzyn321 commented Dec 18, 2019

Description

Changes proposed in this pull request:

  • Fix core configuration (nonexistent property was used)
  • Fix lambda edit mode (issuer was not assigned on load)

Testing scenario:
0. On dev, apply changes made in core/src/app/app.config.ts (use gateway_kyma_project_io_version). It will enable you to display lambda details in APIs view, otherwise request will 404.

  1. Create custom IDP preset.
  2. Create lambda, choosing HTTP Trigger and your custom identity provider.
  3. Go to APIs and select your new lambda. It should display your IDP properly.
  4. Get back to lambda details and refresh the page, then just hit 'Save' button.
  5. If you check out the lambda on APIs again, then without a fix "issuer" field will be brought back to default.

Related issue(s)
Console

@Wawrzyn321 Wawrzyn321 added kind/bug Categorizes issue or PR as related to a bug. area/busola Related to all activities around the Busola UI and all its views labels Dec 18, 2019
@kwiatekus kwiatekus merged commit 500bc55 into kyma-project:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/busola Related to all activities around the Busola UI and all its views kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants