Secure Jaeger UI #681
Merged
Secure Jaeger UI #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
a-thaler,
abbi-gaurav,
devguyio,
derberg,
marcobebway,
montaro,
pbochynski,
PK85 and
sslavic
as code owners
pbochynski
requested changes
Sep 19, 2018
| @@ -8,14 +7,26 @@ spec: | |||
| hosts: | |||
| - jaeger.{{ .Values.global.domainName }} | |||
| gateways: | |||
| - {{ .Values.global.istio.gateway.name }} | |||
| - core-{{ .Chart.Name }}-gateway | |||
There was a problem hiding this comment.
Why can't you use gateway defined for kyma? https://github.com/kyma-project/kyma/blob/master/resources/core/charts/gateway/templates/gateway.yaml
There was a problem hiding this comment.
We have defined a new “security context” only for Jaeger UI which is independent of the others already existing. Therefore, we have a new “static client” for dex, see the related PR.
Jaeger UI will be used by developers in addition to admins or support. Compromising it should not imply that the others are compromised too.
|
|
ghost
added
area/security
montaro
reviewed
Sep 19, 2018
| {{- if .Values.jaeger.memory }} | ||
| args: ["--memory.max-traces={{ .Values.jaeger.memory.maxTraces }}"] | ||
| {{- end }} | ||
| resources: | ||
| {{ toYaml .Values.resources | indent 12 }} | ||
| - image: quay.io/gambol99/keycloak-proxy:v2.2.1 |
There was a problem hiding this comment.
I will update keycloak to the latest version 2.3.0
pbochynski
approved these changes
Sep 20, 2018
devguyio
approved these changes
Sep 20, 2018
change the oauth callback path from kyma-oauth to oauth
|
See also #356 |
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Implements #356