Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify namespace for Istio gateway for Grafana virtual service #7541

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

sisiliao
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Added this line " - {{ .Values.global.istio.gateway.name }}.{{ .Values.global.istio.gateway.namespace }}.svc.cluster.local " to the Grafana virtual service yaml file. With this change, we can specify the namespace for the istio gateway, which solves the issue that the virtual service and the gateway are under 2 different namespaces.

Related issue(s)

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2020

CLA assistant check
All committers have signed the CLA.

@kyma-bot
Copy link
Contributor

Hi @sisiliao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-thaler
Copy link
Contributor

/test all

@a-thaler
Copy link
Contributor

Thanks for your contribution. Indeed we should respect the namespace of the gateway.

@a-thaler
Copy link
Contributor

Hi @sisiliao, please sign the CLA, see the pending github check

@a-thaler a-thaler added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Mar 11, 2020
@a-thaler a-thaler added this to the Sprint_Huskies_21 milestone Mar 11, 2020
@ebensom
Copy link
Member

ebensom commented Mar 11, 2020

Hi @sisiliao , please sign the CLA, that is the only pending check left.

@a-thaler a-thaler merged commit e49b618 into kyma-project:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants