Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type for single documents with name equal to type #829

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Remove type for single documents with name equal to type #829

merged 1 commit into from
Sep 24, 2018

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Sep 20, 2018 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove type for single documents with name equal to type
  • Change behaviour of navigation to display type first

Related issue(s)
Resolves kyma-project/website#23

@akucharska akucharska added kind/feature Categorizes issue or PR as related to a new feature. area/community Related to all activities that are done for Kyma community labels Sep 20, 2018
@akucharska akucharska requested a review from a user September 20, 2018 08:51
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@akucharska akucharska force-pushed the documentation-adjust-types branch 3 times, most recently from 0a5e20f to 933e78d Compare September 21, 2018 11:06
kazydek
kazydek reviewed Sep 24, 2018
View reviewed changes
Copy link

@kazydek kazydek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the type from: https://github.com/kyma-project/kyma/blob/master/docs/application-connector/docs/005-architecture-application-connector.md?

@akucharska akucharska merged commit 99e5631 into kyma-project:master Sep 24, 2018
@akucharska akucharska deleted the documentation-adjust-types branch September 24, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazydek kazydek kazydek approved these changes

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees
No one assigned
Labels
area/community Related to all activities that are done for Kyma community kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akucharska @CLAassistant @kazydek