Enable caching in Serverless and disable colors in logs #8369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudymi
requested review from
aerfio,
anishj0shi,
k15r,
lilitgh,
m00g3n,
magicmatatjahu,
marcobebway,
montaro,
nachtmaar and
pPrecel
as code owners
|
🥰 Documentation preview ready! 🥰 Built with commit 3b41ca0 https://deploy-preview-8369--kyma-project-docs-preview.netlify.app |
|
have a look at https://github.com/GoogleContainerTools/kaniko#--log-format |
|
Yup, I know. I created this PR to generate image :P screens are from changes in |
hudymi
requested review from
alexandra-simeonova,
bszwarc,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj and
tomekpapiernik
as code owners
hudymi
changed the title
hudymi
added
kind/feature
|
I'm not sure if we should configure Let's leave as it is for now. |
hudymi
commented
May 5, 2020
| @@ -88,7 +88,7 @@ func (r *FunctionReconciler) buildJob(instance *serverlessv1alpha1.Function, con | |||
| { | |||
| Name: "executor", | |||
| Image: r.config.Build.ExecutorImage, | |||
| Args: []string{fmt.Sprintf("--destination=%s", imageName), "--insecure", "--skip-tls-verify"}, | |||
| Args: append(r.config.Build.ExecutorArgs, fmt.Sprintf("--destination=%s", imageName), "--context=dir:///workspace"), | |||
There was a problem hiding this comment.
--destination and --context shouldn't be configurable as it is strictly related to volumes and docker repository...
hudymi
changed the title
hudymi
changed the title
hudymi
changed the title
kazydek
approved these changes
May 6, 2020
aerfio
suggested changes
May 6, 2020
| @@ -24,7 +24,8 @@ type BuildConfig struct { | |||
| LimitsMemory string `envconfig:"default=1Gi"` | |||
| LimitsMemoryValue resource.Quantity `envconfig:"-"` | |||
| RuntimeConfigMapName string `envconfig:"default=dockerfile-nodejs-12"` | |||
| ExecutorImage string `envconfig:"default=gcr.io/kaniko-project/executor:v0.19.0"` | |||
| ExecutorArgs []string `envconfig:"default=--insecure;--skip-tls-verify;--skip-unused-stages;--log-format=text;--cache=true"` | |||
There was a problem hiding this comment.
--insecure and --skip-tls-verify shouldn't be set from env
There was a problem hiding this comment.
Not exactly, this is only valid when our internal docker registry is used
components/function-controller/internal/controllers/serverless/function_controller.go
Outdated
Show resolved
Hide resolved
| @@ -100,8 +100,10 @@ containers: | |||
| value: 5m | |||
| functionRequeueDuration: | |||
| value: 5m | |||
| functionBuildExecutorArgs: | |||
| value: "--insecure,--skip-tls-verify,--skip-unused-stages,--log-format=text,--cache=true" | |||
aerfio
approved these changes
May 15, 2020
magicmatatjahu
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Enable caching - when there are no changes in
package.jsonlambda is built in9s, when there are no changes at all then5sand sometimes lessDisable colors in output as it is looking ugly in logs
Before:
After:
Unfortunately, the timestamp column is added by UI...