Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert test #9934

Merged
merged 6 commits into from
Nov 17, 2020
Merged

Add alert test #9934

merged 6 commits into from
Nov 17, 2020

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Nov 11, 2020 •
edited
Loading

Description

Changes proposed in this pull request:

  • add integration test for checking alerts
  • add upgrade test for checking alerts
  • re-enable integration and upgrade tests for checking the health of the targets

Related issue(s)

@shorim shorim added area/monitoring Issues or PRs related to the monitoring module (deprecated) kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. labels Nov 11, 2020
@shorim shorim added this to the 1.18 milestone Nov 11, 2020
@shorim
Copy link
Contributor Author

shorim commented Nov 11, 2020

/test pre-master-kyma-gke-compass-integration

@shorim
Copy link
Contributor Author

shorim commented Nov 11, 2020

/test pre-master-kyma-gke-integration

@shorim
Copy link
Contributor Author

shorim commented Nov 11, 2020

/test pre-master-kyma-gke-compass-integration

@shorim
Copy link
Contributor Author

shorim commented Nov 12, 2020

/test pre-master-kyma-gke-integration

@netlify
Copy link

netlify bot commented Nov 12, 2020

🥰 Documentation preview ready! 🥰

Built with commit 15f478a

https://deploy-preview-9934--kyma-project-docs-preview.netlify.app

@shorim
Copy link
Contributor Author

shorim commented Nov 12, 2020

/test pre-master-kyma-gke-compass-integration

2 similar comments
@shorim
Copy link
Contributor Author

shorim commented Nov 12, 2020

/test pre-master-kyma-gke-compass-integration

@shorim
Copy link
Contributor Author

shorim commented Nov 12, 2020

/test pre-master-kyma-gke-compass-integration

@shorim shorim marked this pull request as ready for review November 17, 2020 08:46
@shorim shorim merged commit 5453b08 into kyma-project:master Nov 17, 2020
@skhalash skhalash mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suleymanakbas91 suleymanakbas91 suleymanakbas91 approved these changes

@a-thaler a-thaler Awaiting requested review from a-thaler

@adamwalach adamwalach Awaiting requested review from adamwalach

@clebs clebs Awaiting requested review from clebs

@crabtree crabtree Awaiting requested review from crabtree

@hisarbalik hisarbalik Awaiting requested review from hisarbalik

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@k15r k15r Awaiting requested review from k15r

@kjaksik kjaksik Awaiting requested review from kjaksik

@ksputo ksputo Awaiting requested review from ksputo

@lilitgh lilitgh Awaiting requested review from lilitgh

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@PK85 PK85 Awaiting requested review from PK85

@polskikiel polskikiel Awaiting requested review from polskikiel

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

Assignees
No one assigned
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario.
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@shorim @suleymanakbas91