Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert "feat: Introduce managed flag to KymaCR .spec.modules (#1652)" #1658

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: Revert "feat: Introduce managed flag to KymaCR .spec.modules (#1652)" #1658

merged 1 commit into from
Jul 3, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jul 3, 2024

This reverts commit b71285f.

Description

Changes proposed in this pull request:

  • reverting the introduction of the field so that we can create a feature branch for the whole deletion mode feature
  • reverting before branching of (and re-introeducing the field in the new branch) because otherwise we would get some troubles when rebasing the feature branch in the future to catch up in main

Related issue(s)

@c-pius c-pius requested review from a team as code owners July 3, 2024 09:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@c-pius c-pius changed the title Revert "feat: Introduce managed flag to KymaCR .spec.modules (#1652)" chore: Revert "feat: Introduce managed flag to KymaCR .spec.modules (#1652)" Jul 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 3, 2024
@c-pius c-pius added the confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of label Jul 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@kyma-bot kyma-bot merged commit 4575398 into kyma-project:main Jul 3, 2024
46 of 48 checks passed
@c-pius c-pius deleted the revert-managed-in-kymacr branch July 3, 2024 10:54
@c-pius c-pius mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@jeremyharisch jeremyharisch jeremyharisch approved these changes

Assignees

@mmitoraj mmitoraj

@jeremyharisch jeremyharisch

Labels
cla: yes Indicates the PR's author has signed the CLA. confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Deletion Modes] Introduce a managed field for each module in the Kyma CR Modules List
4 participants
@c-pius @mmitoraj @jeremyharisch @kyma-bot