Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-add .spec.modules[].managed to KymaCR #1661

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jul 3, 2024

Description

Changes proposed in this pull request:

Related issue(s)

@c-pius c-pius requested review from a team as code owners July 3, 2024 11:41
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jul 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@c-pius c-pius changed the title feat: Re-add '.spec.modules[].managed' to KymaCR feat: Re-add .spec.modules[].managed to KymaCR Jul 3, 2024
@c-pius c-pius force-pushed the feat/re-introduce-managed-to-kymacr-module branch from 8eaba46 to 7a3de8c Compare July 3, 2024 13:33
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 3, 2024
@c-pius c-pius added the confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of label Jul 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@kyma-bot kyma-bot merged commit b47b191 into kyma-project:feat/deletion-mode Jul 3, 2024
46 of 48 checks passed
@c-pius c-pius deleted the feat/re-introduce-managed-to-kymacr-module branch July 3, 2024 13:52
ruanxin pushed a commit to ruanxin/kyma-operator that referenced this pull request Aug 5, 2024
feat: Re-add '.spec.modules[].managed' to KymaCR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants