Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Jenkins working again #810

Merged
merged 4 commits into from May 22, 2022
Merged

Conversation

janden
Copy link
Collaborator

@janden janden commented May 20, 2022

Fetch the new Nvidia apt repo keys since they rotated out their old keys on 2022-04-27 (see https://forums.developer.nvidia.com/t/notice-cuda-linux-repository-key-rotation/212771). Also remove the self-hosted GitHub Actions workflow since we don't have a self-hosted runner currently. Finally, this simplifies some of the PyTorch installation since the Jenkins node now has a V100 and fixes a test that breaks on the torch_skcuda backend.

@janden janden changed the title Fetch new Nvidia repo keys Get Jenkins working again May 20, 2022
Since we have new GPUs, the compute capability problem should no longer
be an issue.
@janden janden marked this pull request as ready for review May 20, 2022 15:46
@janden janden requested a review from eickenberg May 20, 2022 15:46
@lostanlen
Copy link
Collaborator

It's finally working! @janden shall we merge ?

@MuawizChaudhary MuawizChaudhary merged commit ca9073f into kymatio:dev May 22, 2022
@MuawizChaudhary
Copy link
Collaborator

@janden shouldnt this be merged into master?

@janden
Copy link
Collaborator Author

janden commented May 23, 2022

@janden shouldnt this be merged into master?

We'll dev into master with the release of 0.3, then dev will go away. For now, this will let us have a sane CI environment in the meantime.

@MuawizChaudhary
Copy link
Collaborator

so this merge affects the Jenkins whenever we pr into dev? fantastic!

@lostanlen
Copy link
Collaborator

@MuawizChaudhary yes just rebase your PR onto new dev i think

eickenberg pushed a commit that referenced this pull request Jul 5, 2022
* TST Fetch new Nvidia repo keys

* TST Remove self-hosted GHA for now

* TST Get pip torch instead of compiling our own

Since we have new GPUs, the compute capability problem should no longer
be an issue.

* TST Fix broken test_T
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants