Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'NO_CONVERT' is not defined for IPython < 3 import #46

Closed
kynan opened this issue Jan 16, 2017 · 0 comments
Closed

'NO_CONVERT' is not defined for IPython < 3 import #46

kynan opened this issue Jan 16, 2017 · 0 comments
Assignees
@kynan
Labels
resolution:fixed type:bug
Milestone
0.3.0

Comments

@kynan
Copy link
Owner

kynan commented Jan 16, 2017

In the fall through import case for legacy IPython NO_CONVERT is not being defined. Its value doesn't matter since it's ignored in that case.
@kynan kynan added the type:bug label Jan 16, 2017
@kynan kynan self-assigned this Jan 16, 2017
@kynan kynan modified the milestone: 0.3.0 Jan 16, 2017
@kynan kynan closed this as completed in ef77c99 Jan 17, 2017
ooiM added a commit to ooiM/nbstripout that referenced this issue Jun 2, 2020
@ooiM
Define NO_CONVERT for IPython <3 import, closes kynan#46
f845a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kynan kynan

Labels
resolution:fixed type:bug
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@kynan