URL encode paramaters sent with CS request.

kynetx · Jan 10, 2011 · ac29434 · ac29434
1 parent 9b47216
commit ac29434
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/Examples/CocoaApp/Kynetx.m b/Examples/CocoaApp/Kynetx.m
@@ -147,13 +147,14 @@ - (NSURL*) URLFromDict:(NSDictionary*)params withBaseURL:(NSString*)URLstring {
 	NSArray* keys = [params allKeys];
 	int count = [keys count];
 	for (int i = 0; i < count; i++) {
-		id key = [keys objectAtIndex:i];
-		id value = [params objectForKey:key];
+		id key = [[keys objectAtIndex:i] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+		id value = [[params objectForKey:key] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
 		if (i != count - 1) {
 			[buildString appendFormat:@"%@=%@&",key,value];
 		} else {
 			[buildString appendFormat:@"%@=%@",key,value];
 		}
+		NSLog(@"KEY: %@ VALUE: %@", key, value);
 	}
 
 	// at this point, URL is now constructed and ready to be returned

diff --git a/Examples/CocoaApp/MainWindowController.m b/Examples/CocoaApp/MainWindowController.m
@@ -15,7 +15,7 @@ @implementation MainWindowController
 
 - (IBAction) sendTestKynetx:(id) sender {
 	[self setApp:[[[Kynetx alloc] initWithAppID:[appIDField stringValue] eventDomain:@"mobile" delegate:self] autorelease]];
-	NSDictionary* urlParams = [NSDictionary dictionaryWithObjectsAndKeys:@"bar", @"foo", @"whiz", @"cheese", nil];
+	NSDictionary* urlParams = [NSDictionary dictionaryWithObjectsAndKeys:@"bar", @"foo", @"whiz", @"cheese&whiz", nil];
 	[app signal:@"jump_for_joy" params:urlParams];
 }
 

diff --git a/kynetx.m b/kynetx.m
@@ -147,13 +147,14 @@ - (NSURL*) URLFromDict:(NSDictionary*)params withBaseURL:(NSString*)URLstring {
 	NSArray* keys = [params allKeys];
 	int count = [keys count];
 	for (int i = 0; i < count; i++) {
-		id key = [keys objectAtIndex:i];
-		id value = [params objectForKey:key];
+		id key = [[keys objectAtIndex:i] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+		id value = [[params objectForKey:key] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
 		if (i != count - 1) {
 			[buildString appendFormat:@"%@=%@&",key,value];
 		} else {
 			[buildString appendFormat:@"%@=%@",key,value];
 		}
+		NSLog(@"KEY: %@ VALUE: %@", key, value);
 	}
 
 	// at this point, URL is now constructed and ready to be returned