Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use keyring #50

Closed
kyoh86 opened this issue Jan 5, 2020 · 5 comments
Closed

use keyring #50

kyoh86 opened this issue Jan 5, 2020 · 5 comments
Assignees
@kyoh86

Comments

@kyoh86
Copy link
Owner

kyoh86 commented Jan 5, 2020

No description provided.

@kyoh86
Copy link
Owner Author

kyoh86 commented Jan 5, 2020

https://github.com/zalando/go-keyring がなんだかんだ良さそう
中身はexec.Commandだったりするんだけど、他のはcgo使ってたり、
macOSのライブラリ更新に追いつけてなかったりとトラブルが多そう。

@kyoh86
Copy link
Owner Author

kyoh86 commented Jan 5, 2020

.... ξ 99designs/keyring#44
it's low quality library.

@kyoh86
Copy link
Owner Author

kyoh86 commented Jan 5, 2020

ついでに、config get github.tokenでtoken返すのやめたほうがいい。

@kyoh86
Copy link
Owner Author

kyoh86 commented Jan 5, 2020

cli越しに見られるのはいやじゃ

@kyoh86
Copy link
Owner Author

kyoh86 commented Jan 5, 2020

gordonの方で使えそうなことは検証できた。
kyoh86/gordon@27007c6

@kyoh86 kyoh86 closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyoh86 kyoh86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyoh86