Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chafa integration with preview doesn't seem to work... #166

Closed
dkragen opened this issue Dec 18, 2022 · 12 comments
Closed

chafa integration with preview doesn't seem to work... #166

dkragen opened this issue Dec 18, 2022 · 12 comments
Labels
documentation Improvements or additions to documentation

Comments

@dkragen
Copy link

dkragen commented Dec 18, 2022

Hello,

Like felix, but I've run into a problem. Installed via cargo and downloaded and installed chafa. But with preview activated images do not render. Config file (.yaml) doesn't seem to offer any clues as to how to get the two to integrate; at least, using exec chafa [.jpeg,.png,etc] doesn't work, so another mechanism must obtain. Have separately tested chafa on image files; works. Have tested on both alacritty and Xterm. Any ideas?

@kyoheiu
Copy link
Owner

kyoheiu commented Dec 18, 2022

Could you tell me your environment, e.g. OS, window system if linux (X, wayland)?
Also would appreciate if you can provide a screenshot of preview, and the output of chafa --version and fx --version in your terminal.

@dkragen
Copy link
Author

dkragen commented Dec 20, 2022 via email

@kyoheiu
Copy link
Owner

kyoheiu commented Dec 20, 2022

I can't see any attachment, please check.
chafa --version's output is useful, so if you could please paste it here. It must be like this:

Chafa version 1.12.4

Loaders:  GIF ImageMagick JPEG PNG SVG TIFF WebP XWD
Features: mmx sse4.1 popcnt
Applying: mmx sse4.1 popcnt

Copyright (C) 2018-2022 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox
Incl. LodePNG copyright (C) 2005-2018 Lode Vandevenne

This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Basically the image preview feature depends on chafa's output, so if something like chafa image.png does not show image properly, felix cannot show it either. I think it'd be better to test chafa in your terminal first.
Also, I'd like to know whether felix can show other image files or not.

@dkragen
Copy link
Author

dkragen commented Dec 21, 2022 via email

@kyoheiu
Copy link
Owner

kyoheiu commented Dec 21, 2022

Thanks for the response, I still cannot see any attachment/image though.
I'll check if the version is the cause of this later.

As a possibly quick fix, you can download the latest release from GitHub https://github.com/hpjansson/chafa/releases . That might work for you.

@dkragen
Copy link
Author

dkragen commented Dec 21, 2022 via email

@kyoheiu
Copy link
Owner

kyoheiu commented Dec 21, 2022

Ok, now I'm reading this thread via web browser, so could you paste the attachment on #166 ? Thank you.

@kyoheiu
Copy link
Owner

kyoheiu commented Dec 21, 2022

Seems figured out: felix calls chafa with the argument --animate=false, which is needed to show the static frame of gif, but this has been in chafa from v1.10.0, so if you use older version you probably cannot use the image preview. Minimal supported version must be on the document, so I'll add it.
If you could upgrade chafa >= 1.10.0, this problem would be fixed I believe.

@kyoheiu kyoheiu added the bug Something isn't working label Dec 21, 2022
@kyoheiu
Copy link
Owner

kyoheiu commented Dec 21, 2022

Added to the document and help text #167
Thank you for pointing ths issue out! Hope you get the newer version.
If you still have any problem with later version of chafa, please contact me here.

@kyoheiu kyoheiu added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 22, 2022
@kyoheiu
Copy link
Owner

kyoheiu commented Jan 4, 2023

@dkragen Hi, how was this going?

@dkragen
Copy link
Author

dkragen commented Jan 5, 2023 via email

@kyoheiu
Copy link
Owner

kyoheiu commented Jan 5, 2023

Awesome! 👍

@kyoheiu kyoheiu closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants