Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411
Reviewers can test by opening Bob in dev mode in REGTEST and configuring my hosted regtest node as the remote:
protocol:
https
host:
hns-contributor.dev
path:
Network Type:
Regtest
port:
14037
API key:
hellogoodbye-whatsmyname-123
There is one stupid hack here because in hsd
WalletNode
has no option forpath
so ifpathname
is set by user, we have to assemble a URL and pass that as thenodeURL
option toWalletNode
🤷♂️TODO:
LONG-TERM TODO: Allow self-signed cert pinning so remote rpc can connect over https without legacy CA