Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification steps to README #612

Conversation

Copy link
Collaborator

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The PR needs the 2 actions to complete successfully before merge. Removing [ci skip] didn't help. Can you trigger them manually?

@handshake-enthusiast
Copy link
Contributor Author

@rithvikvibhu the commit contains [ci skip] deliberately. Would be great to skip CI on *.md files changes IMO. I can't trigger the actions manually. I can remove [ci skip] from the commit if we can't proceed without completed checks here, but that would be opposite to what I wanted to achieve. Let me know how we proceed.

@rithvikvibhu
Copy link
Collaborator

This project is set up in such a way that those 2 checks must pass to be able to merge PRs, I can't override that.

(Btw this applies to the other PRs also)

@rithvikvibhu rithvikvibhu merged commit c9b4c45 into kyokan:master Feb 21, 2023
@rithvikvibhu
Copy link
Collaborator

Thanks for the recent PRs @handshake-enthusiast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants