chore(typescript): update to 5.3.2 (#5958)

* chore(typescript): update to 5.3.2 * fix: format
kythe · Dec 7, 2023 · 59e73aa · 59e73aa
1 parent fd6d1b5
commit 59e73aa
Show file tree

Hide file tree

Showing 6 changed files with 145 additions and 138 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -19,6 +19,7 @@ kythe_rule_repositories()
 load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")
 
 rules_ts_dependencies(
+    ts_integrity = "sha512-6l+RyNy7oAHDfxC4FzSJcz9vnjTKxrLpDG5M2Vu4SHRVNg6xzqZp6LYSR9zjqQTu8DU/f5xwxUdADOkbrIX2gQ==",
     ts_version_from = "//:package.json",
 )
 

diff --git a/kythe/typescript/BUILD b/kythe/typescript/BUILD
@@ -6,11 +6,11 @@ package(default_visibility = ["//kythe:default_visibility"])
 
 # If you need to add / update dependencies:
 #
-# 0. Ensure you have a recent nodejs and pnpm installed.
-# 1. Edit package.json in this directory as appropriate
+# 0. Ensure you have a recent npm and pnpm. npm can come from apt.
+# 1. Edit //:package.json and //:WORKSPACE as appropriate
 # 2. From the *root dir* of the project, run
 #
-#       cp kythe/typescript/package.json .
+#       npm install
 #       pnpm import
 #
 # 3. Add the dependencies to the ts_project build rule below.

diff --git a/kythe/typescript/indexer.ts b/kythe/typescript/indexer.ts
@@ -1997,6 +1997,7 @@ class Visitor {
       case ts.SyntaxKind.StringLiteral:
       case ts.SyntaxKind.NumericLiteral:
       case ts.SyntaxKind.PrivateIdentifier:
+      case ts.SyntaxKind.NoSubstitutionTemplateLiteral:
         return elem.text;
       case ts.SyntaxKind.ComputedPropertyName:
         const name = this.host.getSymbolAtLocation(elem)?.name;
@@ -2010,7 +2011,6 @@ class Visitor {
         // case" is good enough for now.
         return name !== '__computed' ? name : undefined;
     }
-    return undefined;
   }
 
   /**

diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "once": "^1.4.0",
     "source-map": "^0.7.4",
     "source-map-support": "^0.5.21",
-    "typescript": "5.1.6",
+    "typescript": "5.3.2",
     "wrappy": "^1.0.2"
   },
   "devDependencies": {