feat(api): also filter directories containing only textless entries (#…

…5582)
kythe · Apr 17, 2023 · bd0277b · bd0277b
1 parent 02c7c21
commit bd0277b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/kythe/go/serving/filetree/filetree.go b/kythe/go/serving/filetree/filetree.go
@@ -78,6 +78,9 @@ func (t *Table) Directory(ctx context.Context, req *ftpb.DirectoryRequest) (*ftp
 	}
 	entries := make([]*ftpb.DirectoryReply_Entry, 0, len(d.Entry))
 	for _, e := range d.Entry {
+		if !req.GetIncludeFilesMissingText() && e.GetMissingText() {
+			continue
+		}
 		re := &ftpb.DirectoryReply_Entry{
 			Name:        e.Name,
 			BuildConfig: e.BuildConfig,
@@ -87,9 +90,6 @@ func (t *Table) Directory(ctx context.Context, req *ftpb.DirectoryRequest) (*ftp
 		switch e.Kind {
 		case srvpb.FileDirectory_FILE:
 			re.Kind = ftpb.DirectoryReply_FILE
-			if !req.GetIncludeFilesMissingText() && e.GetMissingText() {
-				continue
-			}
 		case srvpb.FileDirectory_DIRECTORY:
 			re.Kind = ftpb.DirectoryReply_DIRECTORY
 		default:

diff --git a/kythe/proto/filetree.proto b/kythe/proto/filetree.proto
@@ -81,7 +81,8 @@ message DirectoryReply {
     // True if the entry is generated.
     bool generated = 4;
 
-    // Whether the FILE entry is missing text.
+    // Whether the FILE entry is missing text or the DIRECTORY entry contains
+    // only entries with missing_text.
     bool missing_text = 5;
   }
   enum Kind {