Skip to content

Commit

Permalink
fix(proto_verifier_test): remove proto static reflection option (#5702)
Browse files Browse the repository at this point in the history
due to the potential for conflicting aspects/actions, this is an option that should be set globally, not on a per-test basis
  • Loading branch information
justbuchanan committed Jun 13, 2023
1 parent c6e0bfe commit ce9303d
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def cc_proto_verifier_test(
proto_libs,
cc_deps = [],
cc_indexer = "//kythe/cxx/indexer/cxx:indexer",
enable_proto_static_reflection = False,
verifier_opts = [
"--ignore_dups",
# Else the verifier chokes on the inconsistent marked source from the protobuf headers.
Expand All @@ -44,7 +43,6 @@ def cc_proto_verifier_test(
proto_libs: A list of proto_library targets
cc_deps: Additional cc deps needed by the cc test file
cc_indexer: The cc indexer to use
enable_proto_static_reflection: Emit and capture proto static reflection outputs
verifier_opts: List of options passed to the verifier tool
size: Size of the test.
experimental_guess_proto_semantics: guess proto semantics?
Expand Down Expand Up @@ -73,7 +71,7 @@ def cc_proto_verifier_test(
cc_kythe_proto_library,
name = name + "_cc_proto",
deps = proto_libs,
enable_proto_static_reflection = enable_proto_static_reflection,
enable_proto_static_reflection = False,
),
]

Expand Down

0 comments on commit ce9303d

Please sign in to comment.