feat(java_indexer): add method type parameters to MarkedSource (#5882)

kythe · Oct 6, 2023 · dc4b005 · dc4b005
1 parent 93bcd40
commit dc4b005
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/kythe/java/com/google/devtools/kythe/analyzers/java/MarkedSources.java b/kythe/java/com/google/devtools/kythe/analyzers/java/MarkedSources.java
@@ -151,6 +151,22 @@ private static MarkedSource construct(
                 .build());
       }
     }
+    if (sym.getKind() == ElementKind.METHOD && !sym.getTypeParameters().isEmpty()) {
+      MarkedSource.Builder typeParams =
+          markedSource
+              .addChildBuilder()
+              .setKind(MarkedSource.Kind.TYPE)
+              .setPostChildText(" ")
+              .setAddFinalListToken(true)
+              .addChildBuilder()
+              .setKind(MarkedSource.Kind.PARAMETER)
+              .setPreText("<")
+              .setPostText(">")
+              .setPostChildText(", ");
+      for (Symbol t : sym.getTypeParameters()) {
+        typeParams.addChildBuilder().setKind(MarkedSource.Kind.IDENTIFIER).setPreText(t.toString());
+      }
+    }
     if (markedType != null && sym.getKind() != ElementKind.CONSTRUCTOR) {
       markedSource.addChild(markedType);
     }

diff --git a/kythe/javatests/com/google/devtools/kythe/analyzers/java/testdata/pkg/RenderedCode.java b/kythe/javatests/com/google/devtools/kythe/analyzers/java/testdata/pkg/RenderedCode.java
@@ -12,12 +12,28 @@ public final class RenderedCode {
   // - Constructor.code/rendered/callsite_signature "RenderedCode()"
   private RenderedCode() {}
 
+  // - @create defines/binding Create
+  // - Create.code/rendered/qualified_name "pkg.RenderedCode.create"
+  // - Create.code/rendered/signature "public static RenderedCode create()"
+  // - Create.code/rendered/callsite_signature "create()"
+  public static RenderedCode create() {
+    return null;
+  }
+
   // - @Inner defines/binding Inner
   // - Inner.code/rendered/qualified_name "pkg.RenderedCode.Inner"
   // - Inner.code/rendered/signature "public static class Inner<T, U>"
   // - Inner tparam.0 T
   // - T.code/rendered/qualified_name "pkg.RenderedCode.Inner.T"
-  public static class Inner<T, U> {}
+  public static class Inner<T, U> {
+    // - @create defines/binding CreateInner
+    // - CreateInner.code/rendered/qualified_name "pkg.RenderedCode.Inner.create"
+    // - CreateInner.code/rendered/signature "public static <A, B> Inner<A, B> create()"
+    // - CreateInner.code/rendered/callsite_signature "create()"
+    public static <A, B> Inner<A, B> create() {
+      return null;
+    }
+  }
 
   // - @CONSTANT defines/binding Constant
   // - Constant.code/rendered/signature "public static final String CONSTANT"