Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serving protocol buffer definitions [phab:D14] #202

Closed
kythebot opened this issue Jun 25, 2018 · 7 comments
Closed

Add serving protocol buffer definitions [phab:D14] #202

kythebot opened this issue Jun 25, 2018 · 7 comments
Labels
phabricator diff Migrated code review thread from Phabricator

Comments

@kythebot
Copy link
Collaborator

Created by schroederc at 2015-01-30 18:42:27:

Protocol buffer definitions for efficient server lookup tables for the xrefs service and the filetree service.

@kythebot kythebot added the phabricator diff Migrated code review thread from Phabricator label Jun 25, 2018
@kythebot
Copy link
Collaborator Author

fromberger accepted this revision at 2015-01-30 18:55:08

@kythebot
Copy link
Collaborator Author

fromberger commented inline (context lost during migration) at 2015-01-30 18:55:09:

For UIs like CodeSearch, this is likely where we will want to cache target location information. In particular, when the UI gets a reference to some other file, it's usually going to want to paint (say) a snippet and a line number.

(We needn't add that pre-emptively, but I suspect it's going to come back around once we start wiring up the Grok Emacs equivalent)

@kythebot
Copy link
Collaborator Author

fromberger commented inline (context lost during migration) at 2015-01-30 18:55:09:

edge_count maybe

@kythebot
Copy link
Collaborator Author

schroederc wrote at 2015-01-30 19:01:29:

Change field name

@kythebot
Copy link
Collaborator Author

schroederc commented inline (context lost during migration) at 2015-01-30 19:01:35:

Done

@kythebot
Copy link
Collaborator Author

schroederc closed via commit 1ff0d0a at 2015-01-30 19:02:46

@kythebot
Copy link
Collaborator Author

commit 6557b6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
phabricator diff Migrated code review thread from Phabricator
Projects
None yet
Development

No branches or pull requests

1 participant