Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): Fix definition anchors and xrefs in the indexer #4645

Merged
merged 6 commits into from Aug 13, 2020
Merged

fix(rust): Fix definition anchors and xrefs in the indexer #4645

merged 6 commits into from Aug 13, 2020

Conversation

Arm1stice
Copy link
Contributor

@Arm1stice Arm1stice commented Aug 12, 2020 •
edited

This PR does the following:

  • Runs rustfmt on the Rust code
  • Removes the path field from the VName of emitted definitions nodes
  • Removes emitting definitions that are in files we didn't emit file nodes for
  • Makes verifier test for xrefs more complex

@Arm1stice Arm1stice changed the title Remove path from semantic node vname fix(rust): Fix definition anchors and xrefs in the indexer Aug 13, 2020
@Arm1stice Arm1stice marked this pull request as ready for review August 13, 2020 02:13
@Arm1stice Arm1stice requested a review from zrlk August 13, 2020 02:13
@Arm1stice Arm1stice added the buildbot (Obsolete; comment with `/gcbrun` instead) label Aug 13, 2020
@Arm1stice Arm1stice merged commit 00bb640 into kythe:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrlk zrlk zrlk approved these changes

Assignees
No one assigned
Labels
buildbot (Obsolete; comment with `/gcbrun` instead) cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Arm1stice @zrlk @googlebot @wcalandro