feat(extraction): support tree artifacts in bazel extractor #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
It looks like the go-module build fails as well as gofmt checks. |
|
What is go-module build? I don't think I have access to the build logs so no idea why it failed or how to run it locally. With gofmt should be a bit easier. |
|
Ah, we want the Go code to be buildable outside of bazel so also run: |
nbeloglazov
force-pushed
the
extractor-tree-artifacts
branch
from
43f1240
to
e0405fd
Compare
|
I updated this PR. Should be good now. @shahms can you trigger presubmits again? |
|
/gcbrun |
shahms
reviewed
May 19, 2021
nbeloglazov
force-pushed
the
extractor-tree-artifacts
branch
from
3cf6bf7
to
fecc5e1
Compare
|
/gcbrun |
schroederc
suggested changes
May 19, 2021
nbeloglazov
force-pushed
the
extractor-tree-artifacts
branch
from
fecc5e1
to
1fc1c3b
Compare
Usually artifacts in bazel are regular files. But sometimes it can be directories (tree artifacts): https://docs.bazel.build/versions/master/glossary.html#artifact In this case extractor has to recursively include all files in such directories. Had to refactor unit test as now extractor performs file IO so need to initialize all input files by creating empty files.
nbeloglazov
force-pushed
the
extractor-tree-artifacts
branch
from
1fc1c3b
to
ade83a3
Compare
schroederc
reviewed
May 21, 2021
|
/gcbrun |
|
/gcbrun |
schroederc
approved these changes
May 21, 2021
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually artifacts in bazel are regular files. But sometimes it can be directories
(tree artifacts): https://docs.bazel.build/versions/master/glossary.html#artifact
In this case extractor has to recursively include all files in such directories.
Had to refactor unit test as now extractor performs file IO so need to initialize
all input files by creating empty files.