fix(docs): better highlight macos link, remove bazelisk recommendation #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salguarnieri
approved these changes
May 20, 2021
creachadair
reviewed
May 20, 2021
| @@ -63,19 +63,6 @@ for pkg in asciidoc bison brotli flex go graphviz leveldb node openjdk parallel | |||
| brew install $pkg | |||
| done | |||
|
|
|||
| # For Bazel, we recommend using Bazelisk, a wrapper tool that uses | |||
There was a problem hiding this comment.
This leaves macOS users without clear instructions for how to install Bazel. What's the current recommendation, if not to use Bazelisk?
There was a problem hiding this comment.
Wait ... that is on the main "getting started". The "getting started for macOS" is about dependencies. Bazel install instructions are general ("surf to bazel.io and install")
There was a problem hiding this comment.
Fair enough. That didn't used to work. Interestingly, one of their four recommended ways to install Bazel on macOS is via Bazelisk.
(I don't object to omitting the instructions, but I did have to drill about four pages deep into the mess of bazel.io to find that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.