feat(cxx_indexer): Allow VNames as NodeIds for #5037 #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows VNames to be smuggled inside NodeIds. This is necessary because the alternate semantic metadata rules need to be applied inside IndexerASTHooks which only deals in NodeIds. This implementation seemed slightly less evil than encoding a pointer to a VName in a string. I considered using proto wire format, but the lifetimes involved make things hard (the indexer likes to deal in VNameRefs for efficiency (without them IIRC we spent a significant percentage of cycles on copying strings around) and there's nowhere for a temporary VName to go).
shahms
reviewed
Aug 19, 2021
shahms
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows VNames to be smuggled inside NodeIds. This is necessary
because the alternate semantic metadata rules need to be applied
inside IndexerASTHooks which only deals in NodeIds.
This implementation seemed slightly less evil than encoding a pointer
to a VName in a string. I considered using proto wire format, but
the lifetimes involved make things hard (the indexer likes to deal
in VNameRefs for efficiency (without them IIRC we spent a significant
percentage of cycles on copying strings around) and there's nowhere
for a temporary VName to go).