Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go_indexer): fix satisfies check for 1.18beta2 #5235

Merged
merged 2 commits into from
Mar 4, 2022
Merged

fix(go_indexer): fix satisfies check for 1.18beta2 #5235

merged 2 commits into from
Mar 4, 2022

Conversation

schroederc
Copy link
Contributor

No description provided.

@schroederc schroederc added go Issues affecting the Go language indexing Issues pertaining to indexing labels Mar 4, 2022
@schroederc schroederc requested a review from a team March 4, 2022 22:42
jaysachs
jaysachs reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@jaysachs jaysachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests that can be added?

@schroederc
Copy link
Contributor Author

The tests were already there under kythe/go/indexer/testdata/generics. This just fixes them to work with the newest Go version.

@schroederc schroederc merged commit 60bd2fa into kythe:master Mar 4, 2022
@schroederc schroederc deleted the go-generic-satisfies branch March 4, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaysachs jaysachs jaysachs approved these changes

Assignees
No one assigned
Labels
go Issues affecting the Go language indexing Issues pertaining to indexing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schroederc @jaysachs