feat(verifier): allow simplifying graph output data #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. One other thing I was thinking would be nice is to auto-generate labels where they don't exist, based on the node kind, e.g. function123, record124, etc. |
zrlk
approved these changes
May 24, 2022
jaysachs
reviewed
May 24, 2022
| @@ -53,6 +53,10 @@ ABSL_FLAG(std::string, goal_regex, "", | |||
| ABSL_FLAG(bool, convert_marked_source, false, | |||
| "Convert MarkedSource-valued facts to subgraphs."); | |||
| ABSL_FLAG(bool, show_anchors, false, "Show anchor locations instead of @s"); | |||
| ABSL_FLAG(bool, show_vnames, true, | |||
There was a problem hiding this comment.
I wonder if these flag names (as well as other graphviz-related flags) ought to have a dot_ or graphviz_ (or gv_) prefix
There was a problem hiding this comment.
Possibly? In theory they could apply to the JSON dumps as well (but don't currently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two additional verifier flags which control removing the
/kythe/(edge/)?prefix and hiding node VNames when dumping graphviz graphs. This results in much more compact and readable graphs (to say nothing of the dot file itself).This also incidentally updates the PrinterPrinter interface to use absl::string_view instead of
const std::string&