Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java_extractor): disable service processors for Bazel #5368

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

schroederc
Copy link
Contributor

@schroederc schroederc commented Aug 30, 2022

No description provided.

@schroederc schroederc added java Issues affecting the Java language extraction issues affecting Kythe extraction labels Aug 30, 2022
@schroederc schroederc requested a review from a team August 30, 2022 16:23
@schroederc schroederc changed the title fix(java_extractor): disable service processors when extracting from … fix(java_extractor): disable service processors for Bazel Aug 30, 2022
@schroederc schroederc enabled auto-merge (squash) August 30, 2022 16:24
@schroederc schroederc merged commit 1920ad6 into kythe:master Aug 30, 2022
private boolean allowServiceProcessors = true;

/**
* Set whether to allow service processors to be ran during extraction. Defaults to {@code true}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "to run during extraction"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently auto-merge doesn't take into account comments.

@schroederc schroederc deleted the java-service-processors branch August 30, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extraction issues affecting Kythe extraction java Issues affecting the Java language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants