Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxx_indexer): distinguish direct function calls #5378

Merged
merged 4 commits into from
Sep 15, 2022
Merged

feat(cxx_indexer): distinguish direct function calls #5378

merged 4 commits into from
Sep 15, 2022

Conversation

zrlk
Copy link
Contributor

@zrlk zrlk commented Sep 14, 2022

No description provided.

@zrlk
Copy link
Contributor Author

zrlk commented Sep 14, 2022

In partial service of #5379

There are other AST nodes that need supported (like constructor calls).

shahms
shahms reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@shahms shahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a minor question on naming.

kythe/cxx/indexer/cxx/GraphObserver.h Outdated Show resolved Hide resolved
shahms
shahms approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@shahms shahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turnaround on this!

@zrlk zrlk merged commit 134d58a into kythe:master Sep 15, 2022
@zrlk zrlk deleted the invoke-direct branch September 15, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahms shahms shahms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zrlk @shahms