Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(serving): reduce patching to offsets; drop text #5422

Merged
merged 1 commit into from
Nov 2, 2022
Merged

perf(serving): reduce patching to offsets; drop text #5422

merged 1 commit into from
Nov 2, 2022

Conversation

schroederc
Copy link
Contributor

No description provided.

@schroederc schroederc requested a review from a team November 2, 2022 19:08
jaysachs
jaysachs reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@jaysachs jaysachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? While I can follow the code, it's difficult to understand the intent of the change.

@schroederc
Copy link
Contributor Author

The existing tests already cover this. We just don't need the text held in the Patcher.

@schroederc schroederc enabled auto-merge (squash) November 2, 2022 21:52
@schroederc schroederc merged commit 69bef08 into kythe:master Nov 2, 2022
@schroederc schroederc deleted the patch-offsets branch November 2, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaysachs jaysachs jaysachs approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schroederc @jaysachs