feat(java_indexer): implement ref/writes edges #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysachs
reviewed
Nov 3, 2022
kythe/javatests/com/google/devtools/kythe/analyzers/java/testdata/pkg/Writes.java
Show resolved
Hide resolved
kythe/javatests/com/google/devtools/kythe/analyzers/java/testdata/pkg/Writes.java
Show resolved
Hide resolved
| // at least one call to emitNameUsage. We just have to initialize to null to keep the compiler | ||
| // happy. | ||
| JavaNode node = null; | ||
| if (refType == RefType.READ || refType == RefType.READ_WRITE) { |
There was a problem hiding this comment.
Make this a switch statement? It's odd that both branches match READ_WRITE.
There was a problem hiding this comment.
I could potentially do a switch. This is just based on the logic from Cody's implementation for Go.
kythe/java/com/google/devtools/kythe/analyzers/java/KytheTreeScanner.java
Show resolved
Hide resolved
schroederc
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ref/writesedges to the Java indexer. The edges are emitted for variables and class members. See the verifier test for a full representation of whenref,ref/writes, or both edges are emitted.