feat(serving): support scoped cross-references #5530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only adds support to the ScopedReferences in the serving data, and the actual server will unwrap them into unscoped references. A future change will support ScopedReferences in the CrossReferences API.
justbuchanan
approved these changes
Mar 9, 2023
creachadair
reviewed
Mar 9, 2023
| @@ -276,6 +276,20 @@ message PagedCrossReferences { | |||
| int32 ordinal = 2; | |||
| } | |||
|
|
|||
| // References to the source node with an associated semantic scope. | |||
| message ScopedReference { | |||
There was a problem hiding this comment.
This seems like an interesting change! Will this require any schema changes for the indexers to generate the scope data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only adds support to the ScopedReferences in the serving data, and the actual server will unwrap them into unscoped references. A future change will support ScopedReferences in the CrossReferences API.