fix(cxx_extractor): the main source file should be marked always_process #5537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some argument to be made that this logic should (also?) go in the indexer as the indexer should always process the primary source file, regardless of claiming, but we already have a facility for this in the extractor and just need to change one place so that the primary source file is always processed.
Background: when using dynamic claiming, prospective claims are issued with a timeout, but if a given compilation unit abandoned midway through indexing it can sometimes be retried before the previous prospective claims have expired, thus skipping files which it should index. While this is problematic for header files as well, it is most troublesome for source files which are unlikely to be indexed at all as a result. Header files may potentially be included by another compilation unit and therefore indexed separately.
Pros of this approach: very small change, uses pre-existing facility.
Cons: