Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): add ref/id edges for shorthands #5569

Merged
merged 2 commits into from
Apr 11, 2023
Merged

feat(typescript): add ref/id edges for shorthands #5569

merged 2 commits into from
Apr 11, 2023

Conversation

nbeloglazov
Copy link
Collaborator

@nbeloglazov nbeloglazov commented Apr 7, 2023 •
edited
Loading

Also refactors code a bit:

  • Exit early when vname is undefined as lot's of logic depends on vname being present.
  • Consistently use ts.is* functions.

@nbeloglazov nbeloglazov enabled auto-merge (squash) April 7, 2023 20:42
@nbeloglazov nbeloglazov enabled auto-merge (squash) April 7, 2023 20:42
@nbeloglazov
Copy link
Collaborator Author

@shahms could you approve?

@nbeloglazov nbeloglazov merged commit 14d3c9d into kythe:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahms shahms shahms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbeloglazov @shahms